Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apollo-server-lambda] Add support for isBase64Encoded #4311

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Jun 25, 2020

This PR adds support for Lambda Proxy when isBase64Encoded: true.

The body must be decoded from base64 before parsing JSON.

https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html

@apollo-cla
Copy link

@styfle: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@styfle
Copy link
Contributor Author

styfle commented Jul 8, 2020

@abernix Is there something wrong with Netlify? The previous commit (5935c81) was passing CI but the changelog commit you added (e621ccb) is now failing CI 🤔

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had to sort out the Netlify build thing — which turns out to be actually affecting the entire repository, not just this PR. As you noted, I added a CHANGELOG.md entry, but now I think this is good to go. Thanks! 😄

@abernix abernix merged commit b830d6e into apollographql:main Jul 8, 2020
@styfle styfle deleted the lambda-isBase64Encoded branch July 8, 2020 16:17
@styfle
Copy link
Contributor Author

styfle commented Jul 8, 2020

@abernix Great, thanks!

What's the best way to get notified when this is released?

I subscribed to GitHub Releases on this repo but it doesn't look like they are used, only tags.

@abernix abernix added this to the Release 2.16.0 milestone Jul 8, 2020
@abernix
Copy link
Member

abernix commented Jul 8, 2020

@styfle I put it on the milestone (2.16.0) where I believe it'll land. I try to drop messages on PRs within a release when the release ships, based on that milestone's contents — It's a manual ergonomic, but not usually too hard for me to remember. 😉

It probably won't be this week — since it'd be great to get a few more things into this release — but I'm trying to get some triaging and releasing done before Tuesday!

@styfle
Copy link
Contributor Author

styfle commented Jul 13, 2020

@abernix Makes sense!

I only see one item in the 2.16.0 Milestone so that should easy enough 😉

Looking forward to this release, thanks 👍

@abernix
Copy link
Member

abernix commented Jul 17, 2020

📣 Published in apollo-server-lambda@2.16.0! Thank you for putting this together.

styfle added a commit to vercel/vercel that referenced this pull request Jul 23, 2020
### Changes
- Add new Runtime: `@vercel/redwood`
- Update `run.js` script to sort packages properly

### Related
- Related to #4539 
- Related to #4535
- Depends on apollographql/apollo-server#4311
@krailler
Copy link

krailler commented Aug 3, 2020

Can anyone see #4430?

@mathix420 mathix420 mentioned this pull request Aug 5, 2020
4 tasks
@mathix420 mathix420 mentioned this pull request Oct 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants